Return same string object when no interpolations were made #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not directly related: But isn't it too costly to allocate a new regexp via |
|
Could we store that interpolation regex object so that it’s not recalculated every call? Possibly on the config object itself? |
|
That is done on the other PR you just commented. |
|
Attempted to resolve the conflicts here after the other PR was merged in to master. Hope I did it right 🤞 |
fatkodima
force-pushed
the
fix-interpolate-same-object
branch
from
54dd66f
to
be2f3a0
Compare
|
Resolved conflicts. |
|
Thank you! |
|
FYI, if you're using See also grosser/gettext_i18n_rails#196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for the details - rails/rails#47421
Even when there are no interpolations,
gsubturnsSafeBufferinto aString- https://github.com/rails/rails/blob/6af9cba73db6296ab9aec7dbeae1e193ea69f09f/activesupport/lib/active_support/core_ext/string/output_safety.rb#L169So we need to preserve the original "string" object.